Hi Paul,
On 12/11/2010 1:34 AM, Paul Walmsley wrote:
On Thu, 9 Dec 2010, Benoit Cousson wrote:
From: Jonathan Bergsagel<jbergsagel@xxxxxx>
Add register address, mask and link to the clksel structure that
were missing in the IVA DPLL mux clock node.
Signed-off-by: Jonathan Bergsagel<jbergsagel@xxxxxx>
Signed-off-by: Benoit Cousson<b-cousson@xxxxxx>
This patch results in a checkpatch warning:
---
WARNING: please, no space before tabs
#23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639:
+^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$
total: 0 errors, 1 warnings, 0 checks, 13 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
---
I've fixed it in the copy in my local branch, but next time, please run
checkpatch.pl and fix any problems before submitting.
Oops, that's my mistake. the original patch was good, and I messed it up
during the merge conflict resolution.
And then on top of that I completely missed this warning due to the
important number of "line over 80 characters" warnings in this series.
I have now a "filter for dummies" to remove that and avoid missing real
warnings in the future.
Thanks,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
