Re: [PATCH] staging: tidspbridge: use the right type for list_is_last

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Omar,

On Wed, 2010-12-08 at 16:20 -0600, Omar Ramirez Luna wrote:
> Removes the following warning:
> 
>   CC [M]  drivers/staging/tidspbridge/rmgr/rmm.o
> drivers/staging/tidspbridge/rmgr/rmm.c: In function 'rmm_alloc':
> drivers/staging/tidspbridge/rmgr/rmm.c:147: warning: passing
> 	argument 1 of 'list_is_last' from incompatible pointer type
> include/linux/list.h:170: note: expected 'const struct list_head *'
> 	but argument is of type 'struct rmm_ovly_sect *'
> 
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@xxxxxx>
> ---
>  drivers/staging/tidspbridge/rmgr/rmm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/tidspbridge/rmgr/rmm.c b/drivers/staging/tidspbridge/rmgr/rmm.c
> index aae8657..5a3f09c 100644
> --- a/drivers/staging/tidspbridge/rmgr/rmm.c
> +++ b/drivers/staging/tidspbridge/rmgr/rmm.c
> @@ -144,7 +144,7 @@ int rmm_alloc(struct rmm_target_obj *target, u32 segid, u32 size,
>  			new_sect->addr = addr;
>  			new_sect->size = size;
>  			new_sect->page = segid;
> -			if (list_is_last(sect, &target->ovly_list))
> +			if (list_is_last(&sect->list_elem, &target->ovly_list))
>  				/* Put new section at the end of the list */
>  				list_add_tail(&new_sect->list_elem,
>  						&target->ovly_list);


Sorry, I added this warning by mistake, so ...

Acked-by: Ionut Nicu <ionut.nicu@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux