On Fri, Dec 10, 2010 at 8:08 PM, Felipe Balbi <balbi@xxxxxx> wrote: > hi, > > On Fri, Dec 10, 2010 at 08:05:39PM +0530, Hema HK wrote: >> >> Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() >> for enabling/disabling the clocks, sysconfig settings. >> >> enable clock, configure no-idle/standby when active and configure force >> idle/standby >> and disable clock when idled. This is taken care by the runtime framework >> when >> driver calls the pm_runtime_get_sync and pm_runtime_put_sync APIs. >> Need to configure MUSB into force standby and force idle mode when usb not >> used >> >> Signed-off-by: Hema HK <hemahk@xxxxxx> >> Cc: Felipe Balbi <balbi@xxxxxx> >> Cc: Tony Lindgren <tony@xxxxxxxxxxx> >> Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> >> Cc: Cousson, Benoit <b-cousson@xxxxxx> >> Cc: Paul Walmsley <paul@xxxxxxxxx> >> --- >> >> drivers/usb/musb/musb_core.h | 2 - >> drivers/usb/musb/omap2430.c | 80 >> +++++++++++-------------------------------- >> 2 files changed, 23 insertions(+), 59 deletions(-) > > Now I see you removed the runtime_resume and runtime_suspend calls from > musb_core. Won't we loose context in that case ? > We need context save/restore when .suspend/.resume are called. That is done anyway in the musb_suspend/ musb_resume_noirq APIs. Moreover we are calling runtime pm with musb_omap2430 dev pointer, so musb runtime_suspend/resume call backs will not be called. Regards, Hema > -- > balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html