Re: [PATCH 3/7 V2] usb: otg: Kconfig: Add Kconfig option for TWL6030 transceiver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2010 at 5:13 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Fri, Dec 10, 2010 at 04:56:40PM +0530, Kalliguddi, Hema wrote:
>>
>> On Fri, Dec 10, 2010 at 2:11 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>>>
>>> On Fri, Dec 10, 2010 at 12:34:35PM +0530, Hema HK wrote:
>>>>
>>>> Added the TWL6030-usb transceiver option in the Kconfig
>>>>
>>>> Signed-off-by: Hema HK <hemahk@xxxxxx>
>>>> Cc: Felipe Balbi <balbi@xxxxxx>
>>>> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
>>>> ---
>>>> drivers/usb/otg/Kconfig |   12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> Index: usb/drivers/usb/otg/Kconfig
>>>> ===================================================================
>>>> --- usb.orig/drivers/usb/otg/Kconfig
>>>> +++ usb/drivers/usb/otg/Kconfig
>>>> @@ -59,6 +59,18 @@ config TWL4030_USB
>>>>          This transceiver supports high and full speed devices plus,
>>>>          in host mode, low speed.
>>>>
>>>> +config TWL6030_USB
>>>> +       tristate "TWL6030 USB Transceiver Driver"
>>>> +       depends on TWL4030_CORE
>>>> +       select USB_OTG_UTILS
>>>> +       help
>>>> +         Enable this to support the USB OTG transceiver on TWL6030
>>>> +         family chips. This TWL6030 transceiver has the VBUS and ID GND
>>>> +         and OTG SRP events capabilities. For all other transceiver
>>>> functionality
>>>> +         UTMI PHY is embedded in OMAP4430. The internal PHY
>>>> configurations APIs
>>>> +         are hooked to this driver through platform_data structure.
>>>> +         The definition of internal PHY APIs are in the mach-omap2
>>>> layer.
>>>> +
>>>
>>> When compiling with this patch:
>>>
>>> drivers/usb/otg/twl6030-usb.c: In function 'twl6030_set_phy_clk':
>>> drivers/usb/otg/twl6030-usb.c:145: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_set_clock'
>>> drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_init':
>>> drivers/usb/otg/twl6030-usb.c:166: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_power'
>>> drivers/usb/otg/twl6030-usb.c:168: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_power'
>>> drivers/usb/otg/twl6030-usb.c: In function 'twl6030_phy_shutdown':
>>> drivers/usb/otg/twl6030-usb.c:182: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_power'
>>> drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_probe':
>>> drivers/usb/otg/twl6030-usb.c:440: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_init'
>>> drivers/usb/otg/twl6030-usb.c: In function 'twl6030_usb_remove':
>>> drivers/usb/otg/twl6030-usb.c:462: error: 'struct twl4030_usb_data' has
>>> no member named 'phy_exit'
>>> make[2]: *** [drivers/usb/otg/twl6030-usb.o] Error 1
>>> make[1]: *** [drivers/usb/otg] Error 2
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [drivers] Error 2
>>> make: *** Waiting for unfinished jobs....
>>>
>>> please fix ASAP or we will loose the merge window.
>>
>> With this patch twl6030_usb file still not added for build, I am
>> wondering how are
>> you getting How are you getting build error?
>
> This is *the* patch that adds it to Kbuild :-) the previous patch
> already added Makefile change.
>
Agree. Got confused with omap_phy_internal.c file.
I am fixing it. I will send you the patches.
Regards,
Hema
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux