Kevin, On Thu, Dec 9, 2010 at 12:01 AM, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: > jean.pihet@xxxxxxxxxxxxxx writes: > >> From: Jean Pihet <j-pihet@xxxxxx> >> >> Some bad interaction between the idle and the suspend paths has been >> noticed: the idle code is called during the suspend enter and exit >> sequences. This could cause corruption or lock-up of resources. >> >> The solution is to move the calls to disable_hlt at the very beginning >> of the suspend sequence (ex. in omap3_pm_begin instead of >> omap3_pm_prepare), and the call to enable_hlt at the very end of >> the suspend sequence (ex. in omap3_pm_end instead of omap3_pm_finish). > > In an earlier version, I thought we agreed to just remove the empty > prepare/finish calls. Can you do that? > > Also, can you base this on top of my recently posted patch: > > [PATCH v3] OMAP2+: PM/serial: fix console semaphore acquire during suspend > > since it touches some of the same code for pm24xx.c Ok sent as '[PATCH v3] OMAP2+: disable idle early in the suspend sequence' Thanks, Jean > > Thanks, > > Kevin > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
