2010/9/30 Tony Lindgren <tony@xxxxxxxxxxx>:
> * Tony Lindgren <tony@xxxxxxxxxxx> [100930 12:07]:
>> * MichaÅ MirosÅaw <mirqus@xxxxxxxxx> [100930 11:57]:
>> > 2010/9/30 Tony Lindgren <tony@xxxxxxxxxxx>:
>> > > * Cory Maccarrone <darkstar6262@xxxxxxxxx> [100930 11:34]:
>> > >> > Looks like also board-sx1-mmc.c and board-h[23]-mmc.c have the
>> > >> > same spotty voltage range.
>> > >> > Cory, care to do a patch that fixes it for all of them?
>> > >> Yeah, I can do that. ÂI'll resubmit this patch too with the fixed up ranges.
>> > > Turns out I already did it :) Care to test/ack this one?
>> >
>> > [...]
>> > > diff --git a/arch/arm/mach-omap1/board-sx1-mmc.c b/arch/arm/mach-omap1/board-sx1-mmc.c
>> > > index 5b33ae8..be5a365 100644
>> > > --- a/arch/arm/mach-omap1/board-sx1-mmc.c
>> > > +++ b/arch/arm/mach-omap1/board-sx1-mmc.c
>> > > @@ -44,7 +44,8 @@ static struct omap_mmc_platform_data mmc1_data = {
>> > >    Â.nr_slots            = 1,
>> > > Â Â Â Â.slots[0] Â Â Â = {
>> > >        Â.set_power       Â= mmc_set_power,
>> > > -        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_30_31 |
>> > > +        .ocr_mask        = MMC_VDD_28_29 | MMC_VDD_29_30 |
>> > > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â MMC_VDD_30_31 | MMC_VDD_31_32 |
>> > > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂMMC_VDD_32_33 | MMC_VDD_33_34,
>> > >        Â.name          = "mmcblk",
>> > > Â Â Â Â},
>> > [...]
>> >
>> > Al least this one seems wrong (haven't checked others) as the
>> > mmc_set_power() ignores vdd parameter. This suggests that the board
>> > supports only one particular voltage, not the whole range.
>>
>> Hmm yeah good catch. With the external power it's board specific.
>
> Most likely they all support only 3.3V cards except for n8x0. Not changing
> the n8x0 for what voltages it handles although it may be missing the
> MMC_VDD_27_28 voltage. Here's the updated patch.
>
> Regards,
>
> Tony
>
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Subject: [PATCH] omap: Fix spotty MMC voltages
> ...
Finally got around to testing this, and it indeed works perfectly for
me. I still get a bunch of weird CMD5 and CMD8 errors on init, but no
ill effects were introduced by it, and the card works fine.
- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
