On Thu, Nov 25, 2010 at 14:01, Varadarajan, Charulatha <charu@xxxxxx> wrote: > On Thu, Nov 25, 2010 at 13:32, Cousson, Benoit <b-cousson@xxxxxx> wrote: >> On 11/25/2010 5:36 AM, Varadarajan, Charulatha wrote: >>> >>> Benoit, >>> >>> On Thu, Nov 25, 2010 at 03:43, Cousson, Benoit<b-cousson@xxxxxx> wrote: >>>> >>>> On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote: >>>>> >>>>> Add GPIO hwmod data for OMAP2420 >>>>> >>>>> Signed-off-by: Charulatha V<charu@xxxxxx> >>>>> --- >>>>> arch/arm/mach-omap2/omap_hwmod_2420_data.c | 229 >>>>> ++++++++++++++++++++++++++++ >>>>> arch/arm/plat-omap/include/plat/gpio.h | 5 + >>>>> 2 files changed, 234 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c >>>>> b/arch/arm/mach-omap2/omap_hwmod_2420_data.c >>>>> index a1a3dd6..c951061 100644 >>>>> --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c >>>>> +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c >>>>> @@ -17,6 +17,7 @@ >>>>> #include<plat/dma.h> >>>>> #include<plat/serial.h> >>>>> #include<plat/i2c.h> >>>>> +#include<plat/gpio.h> >>>>> #include<plat/omap24xx.h> >>>> >>>> Do you still need that header file? >>> >>> Yes, for the gpio_dev_attr >> >> I'm still confused, gpio_dev_attr just contains an int and a bool: > > I am talking about gpio.h file which is required for using > omap_gpio_dev_attr. If you are pointing out omap24xx.h file, > I am not sure. It was in the original code. Okay. I checked. omap24xx.h file is no more required here and I am deleting this header include from this file. Same for OMAP2430 and OMAP3xxx hwmod database files too. -V Charulatha -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html