On 11/25/2010 5:36 AM, Varadarajan, Charulatha wrote:
Benoit,
On Thu, Nov 25, 2010 at 03:43, Cousson, Benoit<b-cousson@xxxxxx> wrote:
On 11/23/2010 3:56 PM, Varadarajan, Charulatha wrote:
Add GPIO hwmod data for OMAP2420
Signed-off-by: Charulatha V<charu@xxxxxx>
[...]
diff --git a/arch/arm/plat-omap/include/plat/gpio.h
b/arch/arm/plat-omap/include/plat/gpio.h
That change should not necessarily be there, it is not directly related to
the subject.
Maybe that should be in an extra patch just before that one.
I merged these two patches because of a comment to introduce
new variables/structures only in the patch where they are used.
Since "omap_gpio_dev_attr" is being used by hwmod DB I merged
these two patches. Do you think that hwmod DB patches should not
be merged with other patches?
Not necessarily, maybe you can just update the changelog and the subject
to indicate that you add a new structure as well in this patch.
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html