On Mon, Nov 22, 2010 at 14:30, DebBarma, Tarun Kanti <tarun.kanti@xxxxxx> wrote:
>> -----Original Message-----
>> From: Varadarajan, Charulatha
>> Sent: Monday, November 22, 2010 1:55 PM
>> To: DebBarma, Tarun Kanti
>> Cc: linux-omap@xxxxxxxxxxxxxxx; Gopinath, Thara; Basak, Partha
>> Subject: Re: [PATCHv4 11/14] OMAP2+: dmtimer: convert to platform devices
>>
>> <<snip>>
>>
>> > +/**
>> > + * omap_timer_init - top level timer device initialization
>> > + *
>> > + * uses dedicated hwmod api to parse through hwmod database for
>> > + * given class names and then build and register the timer device.
>> > + */
>> > +static int __init omap2_dmtimer_device_init(void)
>> > +{
>> > + int ret = omap_hwmod_for_each_by_class("timer",
>> omap2_timer_init, NULL);
>> > +
>> > + if (unlikely(ret))
>> > + pr_debug("%s: device registration FAILED\n", __func__);
>> > +
>> > + return ret;
>> > +}
>> > +arch_initcall(omap2_dmtimer_device_init);
>>
>> While introducing this, calls to omap_dm_timer_init() should be
>> removed. Else, the init
>> will happen twice for dmtimer devices
> This function is called only when the switch-over takes place.
> That is why you still see the omap_dm_timer_init().
> So this is more to do with organizing the patch.
Exactly. Please take care of this.
> I could have introduced this init code as part of platform driver
> Swith-over.
>
> --
> Tarun
>
>>
>> > --
>> > 1.6.0.4
>> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
