RE: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Belisko Marek wrote:
> On Fri, Nov 12, 2010 at 12:47 PM, Samreen <samreen@xxxxxx> wrote:
>> A null pointer check added.
>> 
>> Signed-off-by: Samreen <samreen@xxxxxx>
>> ---
>>  drivers/video/omap2/omapfb/omapfb-main.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>> 
>> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
>> b/drivers/video/omap2/omapfb/omapfb-main.c
>> index 6a704f1..55bed89 100644
>> --- a/drivers/video/omap2/omapfb/omapfb-main.c
>> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
>> @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct
>> omapfb2_device *fbdev)        int r = 0;
>> 
>>        str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); +       if (str ==
>> NULL) +               return -EINVAL;
> Shouldn't be rerutn _ENNOMEM; instead to get correct error code?
[Samreen]
   Will fix this.
>>        strcpy(str, def_mode);
>>        options = str;
>> 
>> --
>> 1.5.6.3
>> 
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap"
>> in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
>> info at  http://vger.kernel.org/majordomo-info.html
>> 
> thank,
> 
> marek--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux