On Fri, Nov 12, 2010 at 12:47 PM, Samreen <samreen@xxxxxx> wrote: > A null pointer check added. > > Signed-off-by: Samreen <samreen@xxxxxx> > --- > Âdrivers/video/omap2/omapfb/omapfb-main.c | Â Â2 ++ > Â1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c > index 6a704f1..55bed89 100644 > --- a/drivers/video/omap2/omapfb/omapfb-main.c > +++ b/drivers/video/omap2/omapfb/omapfb-main.c > @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct omapfb2_device *fbdev) > Â Â Â Âint r = 0; > > Â Â Â Âstr = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); > + Â Â Â if (str == NULL) > + Â Â Â Â Â Â Â return -EINVAL; Shouldn't be rerutn _ENNOMEM; instead to get correct error code? > Â Â Â Âstrcpy(str, def_mode); > Â Â Â Âoptions = str; > > -- > 1.5.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > thank, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
