> -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Friday, November 12, 2010 7:47 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; Kevin Hilman; Gadiyar, Anand; > Cousson, Benoit > Subject: RE: [PATCH v2] OMAP2+: PM: omap_device: API for > set/get MSTANDBY mode > > On Fri, 12 Nov 2010, Paul Walmsley wrote: > > > On Fri, 12 Nov 2010, Paul Walmsley wrote: > > > > > On Thu, 11 Nov 2010, G, Manjunath Kondaiah wrote: > > > > > > > How do we get previous stand by state in this API since > standby mode is > > > > changed with "omap_device_require_no_standby" > > > > > > I don't think it is needed. The API is only valid while > the hwmod is > > > enabled, I think. So *require_no_mstandby() would force > the hwmod into > > > no-MSTANDBY mode, and *release_no_mstandby() would place > it into smart > > > standby if HWMOD_SWSUP_MSTDBY is not set, and no standby > if it is set. > > > > Oops, this last "no standby" should have been "force standby." > > Urk, never mind. Since the hwmod is enabled, it should be > "no standby." Thanks. Looks like, it is HWMOD_SWSUP_MSTANDBY, typo in omap_hwmod.h description. To summarize: idlemode = (oh->flags & HWMOD_SWSUP_MSTANDBY) ? HWMOD_IDLEMODE_NO : HWMOD_IDLEMODE_SMART; _set_master_standbymode(oh, idlemode, &v); > -ENOCOFFEE Now, return 0. -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
