Hello Manju, On Thu, 11 Nov 2010, G, Manjunath Kondaiah wrote: > > -----Original Message----- > > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > > Sent: Thursday, November 11, 2010 4:45 AM > Requirement is - switch to no standby for short time and should be > reverted back to original standby mode. > All the combinations are not required. OK, good. > > 2. Rather than just using a single omap_device_mstandby() > > function call, > > I'd rather see something like omap_device_require_no_standby() and > > omap_device_release_no_standby(). > > s/standby/mstandby ? Thanks, that makes more sense. > > omap_device_require_no_standby() would > > force the initiator port into no-standby. > > omap_device_release_no_standby() would return the initiator port > > MSTANDBYMODE to whatever the state should be (this depends on whether > > HWMOD_SWSUP_MSTDBY is set). > > How do we get previous stand by state in this API since standby mode is > changed with "omap_device_require_no_standby" I don't think it is needed. The API is only valid while the hwmod is enabled, I think. So *require_no_mstandby() would force the hwmod into no-MSTANDBY mode, and *release_no_mstandby() would place it into smart standby if HWMOD_SWSUP_MSTDBY is not set, and no standby if it is set. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html