Hello Felipe, On Thu, 11 Nov 2010, Felipe Contreras wrote: > On Thu, Nov 11, 2010 at 2:00 AM, Paul Walmsley <paul@xxxxxxxxx> wrote: > > > > I see that you modified my original patch, but it seems that you also > > dropped my Signed-off-by:. > > Yes, because you didn't s-o-b my changes. I got that complaint from Catalin. I have reviewed my paul@xxxxxxxxx inbox. I didn't see any request from you to review the changes. But perhaps it was inadvertently dropped at some point in the mail path between you and I. > > This is a tricky situation, to be sure. > > Probably the best thing to do in these cases if you don't wish to ask me > > to review the modified patch, is to keep my original Signed-off-by: -- > > since I wrote the patch, originally -- and then, immediately before your > > Signed-off-by:, to add a bracketed note saying what you changed, e.g., > > > > [felipe.contreras@xxxxxxxxx: dropped some changes, etc.] > > > > That way the provenance of the patch is clear. > > Ok. I was hoping you would review the patch and put your s-o-b. I have reviewed your updated patch; you are welcome to re-add my Signed-off-by:. - Paul
