On Thu, Nov 11, 2010 at 2:00 AM, Paul Walmsley <paul@xxxxxxxxx> wrote: > Hello Felipe, > > On Sun, 7 Nov 2010, Felipe Contreras wrote: > >> From: Paul Walmsley <paul@xxxxxxxxx> >> >> Add two functions for OMAP2430/OMAP3 IVA2 DSP boot control. ÂThese >> registers wound up in the System Control Module. ÂOther kernel code that >> wishes to control the DSP's boot process should now use these functions >> to do so; subsequent patches implement this in the two in-tree users of >> these functions. >> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> > > I see that you modified my original patch, but it seems that you also > dropped my Signed-off-by:. Yes, because you didn't s-o-b my changes. I got that complaint from Catalin. > This is a tricky situation, to be sure. > Probably the best thing to do in these cases if you don't wish to ask me > to review the modified patch, Âis to keep my original Signed-off-by: -- > since I wrote the patch, originally -- and then, immediately before your > Signed-off-by:, to add a bracketed note saying what you changed, e.g., > > [felipe.contreras@xxxxxxxxx: dropped some changes, etc.] > > That way the provenance of the patch is clear. Ok. I was hoping you would review the patch and put your s-o-b. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
