Currently we are enabling the IRQ before queue's are allocated.But in some
corner cases as soon as we enable the interruption,the ISR will be executed
but the queue's wont be ready.Because of this we may be reading some garbage
message in the mailbox which may lead to panic.
This patch is based on the analysis of Fernando Guzman Lugo.
Signed-off-by: Deepak Chitriki <deepak.chitriki@xxxxxx>
---
arch/arm/plat-omap/mailbox.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index c59c9c3..1513e16 100644
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -256,14 +256,6 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
mutex_unlock(&mbox_configured_lock);
}
- ret = request_irq(mbox->irq, mbox_interrupt, IRQF_SHARED,
- mbox->name, mbox);
- if (ret) {
- printk(KERN_ERR
- "failed to register mailbox interrupt:%d\n", ret);
- goto fail_request_irq;
- }
-
mq = mbox_queue_alloc(mbox, NULL, mbox_tx_tasklet);
if (!mq) {
ret = -ENOMEM;
@@ -278,13 +270,21 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
}
mbox->rxq = mq;
+ ret = request_irq(mbox->irq, mbox_interrupt, IRQF_SHARED,
+ mbox->name, mbox);
+ if (ret) {
+ printk(KERN_ERR
+ "failed to register mailbox interrupt:%d\n", ret);
+ goto fail_request_irq;
+ }
+
return 0;
- fail_alloc_rxq:
+fail_request_irq:
+ mbox_queue_free(mbox->rxq);
+fail_alloc_rxq:
mbox_queue_free(mbox->txq);
- fail_alloc_txq:
- free_irq(mbox->irq, mbox);
- fail_request_irq:
+fail_alloc_txq:
if (mbox->ops->shutdown)
mbox->ops->shutdown(mbox);
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
