On Thu, Nov 4, 2010 at 1:15 PM, Ghorai, Sukumar <s-ghorai@xxxxxx> wrote: > > >> -----Original Message----- >> From: Grazvydas Ignotas [mailto:notasas@xxxxxxxxx] >> Sent: Thursday, November 04, 2010 4:42 PM >> To: Ghorai, Sukumar >> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; Artem.Bityutskiy@xxxxxxxxx; Vimal Singh; Tony >> Lindgren >> Subject: Re: [PATCH RESEND v5 4/5] omap: nand: ecc layout select from >> board file >> >> > [Ghorai] In 2.6.36, it's a s/w ecc by default and working in all >> platforms like - omap3430 SDP, zoom2, 3630SDP, ZOOM3. >> > So please explain more when you found that - sw ecc is broken on both >> 2.6.36 >> >> It doesn't for me, see >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux- >> 2.6.git;a=blob;f=drivers/mtd/nand/omap2.c;h=513e0a76a4a73866d52bba8151e435 >> 56a3b30a54;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f >> >> This is omap NAND driver at v2.6.36 tag, and it has >> CONFIG_MTD_NAND_OMAP_HWECC forced. > > [Ghorai] This is the same old code since log. And this portion of code not touched for 2.6.36. > And please let me know what kind of problem you are facing when you using 2.6.36; also let me know how to reproduce, I can check in my platform too. It has changed in 2.5.36, take a look how it was in 2.6.35, when it worked for me: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/mtd/nand/omap2.c;h=ee87325c7712a8eeee4bbc683f93014c9901f337;hb=9fe6206f400646a2322096b56c59891d530e8d51 notice how 2.5.36 has CONFIG_MTD_NAND_OMAP_HWECC defined and 2.6.35 doesn't. The test case is simple: format and use NAND on 2.6.35 or earlier, works fine. upgrade to 2.6.36 or 2.6.37-rc1 and try to mount the same NAND partition - lots of ECC errors. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
