> -----Original Message----- > From: Grazvydas Ignotas [mailto:notasas@xxxxxxxxx] > Sent: Thursday, November 04, 2010 4:27 PM > To: Ghorai, Sukumar > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; Artem.Bityutskiy@xxxxxxxxx; Vimal Singh; Tony > Lindgren > Subject: Re: [PATCH RESEND v5 4/5] omap: nand: ecc layout select from > board file > > On Thu, Nov 4, 2010 at 12:15 PM, Ghorai, Sukumar <s-ghorai@xxxxxx> wrote: > >> -----Original Message----- > >> From: Grazvydas Ignotas [mailto:notasas@xxxxxxxxx] > >> OMAP3 pandora. > >> What I wanted to say is that current mainline code has hw ECC forced > >> which is wrong for some boards, and this patch did not make into last > >> merge window, so NAND is broken. It would be good to take this patch > >> out of larger series you sent earlier and resend as a fix for -rc1, so > >> that NAND works on 2.6.37. It's not too large and should probably be > >> ok for -rc2. > > > > [Ghorai] > > There is an additional patch I will send (with this series by next week) > to select the ECC from board file, such that different board file can > select the different ECC method. > > > > 1. This is mainly for OMAP3630 onwards and has been aligned with many > customers to use the hw ecc. > > > > 2. I did not understand how it's not working, would you please explain > again? If you apply the series then it's storing the same ecc value in > different location and generated from h/w module. > > It most likely works (need to test more), I was just complaining it's > not upstream and sw ecc is broken on both 2.6.36 and 2.6.37. [Ghorai] In 2.6.36, it's a s/w ecc by default and working in all platforms like - omap3430 SDP, zoom2, 3630SDP, ZOOM3. So please explain more when you found that - sw ecc is broken on both 2.6.36 > > > 3. This patches are not upstream yet; send me the git-link you referring > that these patches are available in 2.6.37? > Correct, they are not upstream, so that's why suggest sending smaller > fix patch for 2.6.37-rc2, so that sw ecc works on 2.6.37. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
