On Fri, Oct 22, 2010 at 6:08 PM, Ionut Nicu <ionut.nicu@xxxxxxxxxx> wrote: > On Fri, 2010-10-22 at 16:36 +0300, Felipe Contreras wrote: >> On Fri, Oct 22, 2010 at 3:59 PM, Ionut Nicu <ionut.nicu@xxxxxxxxx> wrote: >> > The current code was always returning a non-zero status value >> > to userspace applications when this ioctl was called. >> > >> > The error code was ENODATA, which isn't actually an error, >> > it's always returned by dcd_enumerate_object() when it hits the >> > end of list. >> > >> > Reorganized the code so that it works like "dynreg.out -ln" from >> > the userspace-dspbridge package expects it to work. >> > >> > Signed-off-by: Ionut Nicu <ionut.nicu@xxxxxxxxxx> >> >> I also found this issue, but I have simpler fix. I think my fix should >> be applied first, and then your reorganization. >> > > Yeah, mine looks more complex because of the code cleanup in > mgr_enum_node_info(). > > Anyway I don't have anything against applying your patch first. If your > patch gets merged, I'll rebase my changes and submit a new one with the > code cleanup. Or you can put it into the next version of your patch series :) -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
