Tony Lindgren <tony@xxxxxxxxxxx> writes: > * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [101020 16:22]: >> Currently in the idle path, we have custom function calls into device >> code to handle device specific actions that need to be coordinated CPU >> idle transitions. Rather than continue this ad-hoc method of calling >> device code from the PM core, create a formal way for device/driver >> code to register for idle notifications. >> >> Idle notifications are done late in the idle path when interrupts are >> disabled, hence use atomic notifier chains. These notifications will >> also be atomic with respect to CPU idle transitions. > > ... > >> +EXPORT_SYMBOL_GPL(omap_idle_notifier_register); >> +EXPORT_SYMBOL_GPL(omap_idle_notifier_unregister); > > Let's rather set this up as a generic framework to avoid adding > more omap specific frameworks to the drivers. Hmm, I thought I removed those EXPORT_SYMBOLs, just for that reason. I actually don't really intend these to be used from drivers, but only from OMAP-specific device code. We currently use these manly for errata purposes, but also for UART debug purposes, and only from device code currently. That being said, I did consider a generic framework for this (x86_64 has it's own idle notfiers as well), and this topic something already on the table for LPC PM miniconf. However, at least for OMAP, the location of when the notifiers are triggered has to be in OMAP-specific code. It cannot be in the ARM-generic idle path (like they do in x86_64.) The reason is because the idle notifiers have to be called *after* the OMAP-specific idle path has programmed the next power states for the various power domains. That way, the idle notifiers can read the next power state regs and make decisons on what they need to do (or not to do) based on whether he power domain is going to RET, OFF, etc. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
