Re: [PATCH v3 09/11] OMAP3: PM: Smartreflex Class3 initialization from board files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Gopinath, Thara" <thara@xxxxxx> writes:

>>>> This patch enables smartreflex class3 functionality for OMAP3430SDP,
>>>> OMAP3630SDP, ZOOM2 and ZOOM3 boards.
>>>
>>>This patch doesn't touch 3630sdp.
>>>
>>>> Signed-off-by: Thara Gopinath <thara@xxxxxx>
>>>
>>>I'm having some doubts about whether this should be done by board files or
>>>not.  Seems like the general case will be that by default will be SoC
>>>specific, and only boards that want something other than the default
>>>class should need to override this.
>>>
>>>Thoughts?
>
> I agree. I wanted this to be a default initcall and one to enable the
> menuconfig option for the required class driver.. But Nishant wanted
> this from board files. 

And I want both.  :)

> If we have consensus in removing this init from board file, I am cool
> with it.

I want to suport a kernel that could be built with all possible classes
supported.  e.g. an omap3/4 kernel that has both class 1.5 and class 3
support.

If both are enabled in Kconfig, then either could be used.  We'll have
to pick one as the default initcall (e.g. highest class present), but if
a board file chooses to call a different one, that should override the
default one.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux