>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Friday, October 15, 2010 5:20 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, >>Vishwanath; Sawant, Anand >>Subject: Re: [PATCH v3 09/11] OMAP3: PM: Smartreflex Class3 initialization >>from board files. >> >>Thara Gopinath <thara@xxxxxx> writes: >> >>> This patch enables smartreflex class3 functionality for OMAP3430SDP, >>> OMAP3630SDP, ZOOM2 and ZOOM3 boards. >> >>This patch doesn't touch 3630sdp. >> >>> Signed-off-by: Thara Gopinath <thara@xxxxxx> >> >>I'm having some doubts about whether this should be done by board files or >>not. Seems like the general case will be that by default will be SoC >>specific, and only boards that want something other than the default >>class should need to override this. >> >>Thoughts? I agree. I wanted this to be a default initcall and one to enable the menuconfig option for the required class driver.. But Nishant wanted this from board files. If we have consensus in removing this init from board file, I am cool with it. Regards Thara >> >>Kevin >> >>> --- >>> arch/arm/mach-omap2/board-3430sdp.c | 2 ++ >>> arch/arm/mach-omap2/board-zoom-peripherals.c | 2 ++ >>> 2 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach- >>omap2/board-3430sdp.c >>> index 67b95b5f..9a04a2e 100644 >>> --- a/arch/arm/mach-omap2/board-3430sdp.c >>> +++ b/arch/arm/mach-omap2/board-3430sdp.c >>> @@ -47,6 +47,7 @@ >>> #include "sdram-qimonda-hyb18m512160af-6.h" >>> #include "hsmmc.h" >>> #include "pm.h" >>> +#include "smartreflex-class3.h" >>> >>> #define CONFIG_DISABLE_HFCLK 1 >>> >>> @@ -813,6 +814,7 @@ static void __init omap_3430sdp_init(void) >>> sdp3430_display_init(); >>> enable_board_wakeup_source(); >>> usb_ehci_init(&ehci_pdata); >>> + sr_class3_init(); >>> } >>> >>> MACHINE_START(OMAP_3430SDP, "OMAP3430 3430SDP board") >>> diff --git a/arch/arm/mach-omap2/board-zoom-peripherals.c b/arch/arm/mach- >>omap2/board-zoom-peripherals.c >>> index 6b39849..98dffc6 100644 >>> --- a/arch/arm/mach-omap2/board-zoom-peripherals.c >>> +++ b/arch/arm/mach-omap2/board-zoom-peripherals.c >>> @@ -26,6 +26,7 @@ >>> >>> #include "mux.h" >>> #include "hsmmc.h" >>> +#include "smartreflex-class3.h" >>> >>> /* Zoom2 has Qwerty keyboard*/ >>> static int board_keymap[] = { >>> @@ -282,4 +283,5 @@ void __init zoom_peripherals_init(void) >>> omap_i2c_init(); >>> usb_musb_init(&musb_board_data); >>> enable_board_wakeup_source(); >>> + sr_class3_init(); >>> } -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
