Ohad Ben-Cohen <ohad@xxxxxxxxxx> writes: > On Tue, Oct 19, 2010 at 7:16 PM, Kevin Hilman > <khilman@xxxxxxxxxxxxxxxxxxx> wrote: >> Ohad Ben-Cohen <ohad@xxxxxxxxxx> writes: >> >>> From: Simon Que <sque@xxxxxx> >>> >>> Add driver for OMAP's Hardware Spinlock module. >>> >>> The OMAP Hardware Spinlock module, initially introduced in OMAP4, >>> provides hardware assistance for synchronization between the >>> multiple processors in the device (Cortex-A9, Cortex-M3 and >>> C64x+ DSP). >> > ... > >>> +config OMAP_HWSPINLOCK >>> + Â Â bool "OMAP Hardware Spinlock module" >> >> Should be tristate > > Agree, > >> so it can also be built as a module by default. >> >> e.g., when building multi-OMAP kernels, no reason or this to be >> built-in. ÂIt can then be loaded as a module on OMAP4 only. > > But considering the current built-in use cases (i2c) we would then > need to have the relevant MACH_OMAP4_* select OMAP_HWSPINLOCK (only on > the OMAP4 machines on which the I2C bus is shared). Yes, that is ok. At least then it can be tested by default as a module. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html