On Monday 18 October 2010 09:44:33 Ohad Ben-Cohen wrote: > + int omap_hwspin_lock(struct omap_hwspinlock *hwlock, unsigned long *flags); > ... > + The flags parameter is a pointer to where the interrupts state of the > + caller will be saved at. This seems to encourage sloppy coding: The only variant you allow is the one that corresponds to Linux's spin_lock_irqsave(), which is generally discouraged in all places where you know if you need to disable interrupts or not. IMHO the default should be a version that only allows locks that don't get taken at IRQ time and consequently don't require saving the interrupt flags. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
