srinath@xxxxxxxxxxxxxxxxxxxx had written, on 10/15/2010 05:27 AM, the
following:
From: Srinath <srinath@xxxxxxxxxxxxxxxxxxxx>
This series adds support for the AM3517/05 based craneboard. We are a team of
engineers working at Mistral Solutions and will be sending patches to support
this board. Request you to review and accept these patches.
Added board file for AM3517/05 craneboard
Srinath (1):
Added-craneboard-basic-support
arch/arm/configs/omap2plus_defconfig | 1 +
arch/arm/mach-omap2/Kconfig | 6 +++
arch/arm/mach-omap2/Makefile | 2 +
arch/arm/mach-omap2/board-am3517crane.c | 68 +++++++++++++++++++++++++++++++
4 files changed, 77 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-omap2/board-am3517crane.c
Few suggestions:
Please read:
http://omapedia.org/wiki/Releasing_to_Linux_kernel_using_patches_and_emails
http://elinux.org/Git_usage
on how to generate patches and post them
for example this covering letter is completely unnecessary,
the patch1 $subject should have been:
OMAP: AM3517/05: board: Add craneboard support
All this info that you put in covering letter should have been part of
the patch - remember to add a link to craneboard - most of us might not
be aware of this board at all. this is the information that will be
stored in git commit log for ever+ it has to also flow down from
linux-omap down to linux-arm, lkml etc.. imagine yourself being a
developer for ppc/intel processor and looking at this patch - the commit
message and $subject should explain to them as well..
more as part of patch 1 review comments.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
