fernando.lugo@xxxxxx wrote:
> > On Mon, Oct 11, 2010 at 6:33 PM, Guzman Lugo, Fernando
> > <fernando.lugo@xxxxxx> wrote:
> > >> > @@ -420,7 +431,8 @@ static void sgtable_fill_kmalloc(struct
> > >> sg_table
> > >> > *sgt, u32 pa, size_t len)
> > >> > Â Â Â Â for_each_sg(sgt->sgl, sg, sgt->nents, i) {
> > >> > Â Â Â Â Â Â Â Â size_t bytes;
> > >> >
> > >> > - Â Â Â Â Â Â Â bytes = iopgsz_max(len);
> > >> > + Â Â Â Â Â Â Â bytes = max_alignment(da | pa);
> > >> > + Â Â Â Â Â Â Â bytes = min(bytes, (size_t)iopgsz_max(len));
> > >>
> > >> Why the size_t casting?
> > >
> > > To void this warning:
> > > arch/arm/plat-omap/iovmm.c:440: warning: comparison of distinct
> > > pointer types lacks a cast
> >
> > But how is that possible? iopgsz_max is returning constants,
> > like SZ_1M, so they should not need casts, if anything, the
> > cast should be done in iopgsz_max itself.
>
> The min macro make a "typeof" of the parameter, so the typeof of a
> Constants should be int I think and that's the reason of the warning.
>
> I can use min_t instead to avoid the warning, something like this:
>
> bytes = min_t(size_t, bytes, iopgsz_max(len));
>
> What do you think?
Right, I forgot about that one... much better.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
