Re: [PATCHv2 2/3] iovmm: add superpages support to fixed da address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 11, 2010 at 6:33 PM, Guzman Lugo, Fernando
<fernando.lugo@xxxxxx> wrote:
>> > @@ -420,7 +431,8 @@ static void sgtable_fill_kmalloc(struct
>> sg_table
>> > *sgt, u32 pa, size_t len)
>> > Â Â Â Âfor_each_sg(sgt->sgl, sg, sgt->nents, i) {
>> > Â Â Â Â Â Â Â Âsize_t bytes;
>> >
>> > - Â Â Â Â Â Â Â bytes = iopgsz_max(len);
>> > + Â Â Â Â Â Â Â bytes = max_alignment(da | pa);
>> > + Â Â Â Â Â Â Â bytes = min(bytes, (size_t)iopgsz_max(len));
>>
>> Why the size_t casting?
>
> To void this warning:
> arch/arm/plat-omap/iovmm.c:440: warning: comparison of distinct pointer types lacks a cast

But how is that possible? iopgsz_max is returning constants, like
SZ_1M, so they should not need casts, if anything, the cast should be
done in iopgsz_max itself.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux