Hello Senthil, On Wed, 6 Oct 2010 16:44:55 +0530 Guruswamy Senthilvadivu <svadivu@xxxxxx> wrote: > static struct { > + struct platform_device *pdev; > void __iomem *base; > > u32 fifo_size[3]; > @@ -189,11 +190,22 @@ static inline u32 dispc_read_reg(const struct dispc_reg idx) > /* DISPC HW IP initialisation */ > static int omap_dispchw_probe(struct platform_device *pdev) > { > - return 0; > + int r; > + dispc.pdev = pdev; > + > + r = dispc_init(); > + if (r) { > + DSSERR("Failed to initialize dispc\n"); > + goto err_dispc; > + } > + > +err_dispc: > + return r; > } > > static int omap_dispchw_remove(struct platform_device *pdev) > { > + dispc_exit(); > return 0; > } Same comments than the one for the patch on the RFBI driver. Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html