On 10/7/2010 10:44 AM, Guruswamy, Senthilvadivu wrote:
From: Cousson, Benoit
Sent: Thursday, October 07, 2010 12:47 PM
Hi Senthil,
On 10/7/2010 8:16 AM, Guruswamy, Senthilvadivu wrote:
From: Premi, Sanjeev
From: linux-omap-owner@xxxxxxxxxxxxxxx
From: Senthilvadivu Guruswamy<svadivu@xxxxxx>
Move init exit methods to its driver probe,remove.
pdev member has to be maintained by its own drivers.
[sp] How is this change related to hwmod mentioned in the
subject line?
[Senthil] As part of the hwmod design, dispc is made as platform driver.
Hence the dispc_init and dispc_exit has to be moved from core
"omapdisplay"
Driver to "dss_dispc" platform driver. Pdev is the platform device
structure maintained in dss_dispc driver containing silicon specific info
like baseaddr, irqs of DISPC HW.
It is still not a reason to put hwmod in the subject. That is valid for
most patches of this series.
You have to put the plaform name then the subsystem if this is related
to the OMAP arch directory, which is DSS, not hwmod DSS.
In the case of DSS driver changes, then you should start with video:
DSS:, or maybe DSS is enough if there is no possible confusion.
The goal of that is just to highlight in the subject what part of the
kernel you are changing, since the maintainers are not necessarily the
same.
[Senthil] If "hwmod" is creating confusion, it could be removed.
Is it an ack for this patch series considering that "change in the header" is the only comment to be incorporated?
Mmm, not really, but since it is the subject, this is the very first
things you see. That why it is important to provide good subject :-)
I'll have a look at this series before the end of the week.
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
