Peter, > -----Original Message----- > From: Peter Ujfalusi [mailto:peter.ujfalusi@xxxxxxxxx] > Sent: Monday, October 04, 2010 12:46 PM > To: G, Manjunath Kondaiah > Cc: Jarkko Nikula; Tony Lindgren; linux-omap@xxxxxxxxxxxxxxx; > Liam Girdwood > Subject: Re: [PATCH v3 1/2] omap: dma: Fix buffering disable > bit setting for omap24xx > > On Monday 04 October 2010 09:23:18 ext G, Manjunath Kondaiah wrote: > > No errata numbers numbers used with TI errata documents > till omap2430. > > Errata numbers avaialable from omap3430 onwards. > > > > > For OMAP3 the errata number is i541, but I do not know the iXYZ > > > number for OMAP2 class. > > > > Being said that no errata numbers for omap2 class, it's ok to use > > omap3 errata numbers for common errata(like your patch 2/2) > > Thanks, > we are going to use the same errata ID for OMAP2, and OMAP3, > but going to use different workaround for them: > OMAP2: disable buffering This issue seems to be completly different from omap3 i541. This is required to flush out fifo contents properly where as with i541, it requires DMA controller to be put in no mstandby mode before stoping DMA transfer. > OMAP3: implement the workaround as it is in the errata > > So, as Tony suggested, I'll add the errata handling, and we If you are introducing errata handling, are you taking care of existing errata in DMA driver also? If not, it is better to go ahead current implementation. DMA hwmod patches will introduce errata handling and these changes can be rebased once it is available in mainline. > are going to have: > DMA_ERRATA_i541_OMAP2, and DMA_ERRATA_i541_OMAP3 to For OMAP2, you should use "DMA_ERRATA_IFRAME_BUFFERING" since it is different type of issue. -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
