> -----Original Message----- > From: Jarkko Nikula [mailto:jhnikula@xxxxxxxxx] > Sent: Monday, October 04, 2010 11:13 AM > To: G, Manjunath Kondaiah > Cc: Peter Ujfalusi; Tony Lindgren; > linux-omap@xxxxxxxxxxxxxxx; Liam Girdwood > Subject: Re: [PATCH v3 1/2] omap: dma: Fix buffering disable > bit setting for omap24xx > > On Sat, 2 Oct 2010 10:12:50 +0530 > "G, Manjunath Kondaiah" <manjugk@xxxxxx> wrote: > > > > --- a/arch/arm/plat-omap/dma.c > > > +++ b/arch/arm/plat-omap/dma.c > > > @@ -1000,7 +1000,7 @@ void omap_start_dma(int lch) > > > * This will always fail on ES1.0 > > > */ > > > if (cpu_is_omap24xx()) > > > - l |= OMAP_DMA_CCR_EN; > > > + l |= OMAP_DMA_CCR_BUFFERING_DISABLE; > > > > This issue is applicable only for 2430ES1.0(not sure about > 2420) and > > it got fixed with later ES versions. > > cpu check should be replaced with: > > > > if (cpu_is_omap2420() || (cpu_is_omap2430() && (omap_type() == > > OMAP2430_REV_ES1_0))) > > > Ok, thanks for your info, I'll change this. > > How about later versions of 2430? Fixed in later versions ES2.0 and ES2.1 > Should they use the workaround in Patch 2/2? 2/2 is applicable for all omap2plus except omap4. So far 2/2 workaround is not used with TI internal trees. > We experimented that also on 2420 and it seemed to help but since the lockup was unrecovable I > went thinking if 2420 has also another issue what original > workaround was trying to fix and buffering disable was needed there. I don't have any data for 2420. Based on your observation, it is better to disable buffering for 2420. -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
