Hi, On Fri, Oct 01, 2010 at 11:09:04PM +0200, ext Enric Balletbo i Serra wrote: > GPIO for various devices are missing from the board initialization. > This patch adds support for the VBUS and over current gpios. Without this > patch, input/outputs from these two sources are ignored. > > Signed-off-by: Enric Balletbo i Serra <eballetbo@xxxxxxxxx> > --- > arch/arm/mach-omap2/board-igep0020.c | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c > index 175f043..07dbdb7 100644 > --- a/arch/arm/mach-omap2/board-igep0020.c > +++ b/arch/arm/mach-omap2/board-igep0020.c > @@ -274,6 +274,22 @@ static int igep2_twl_gpio_setup(struct device *dev, > igep2_vmmc1_supply.dev = mmc[0].dev; > igep2_vmmc2_supply.dev = mmc[1].dev; > > + /* > + * REVISIT: need ehci-omap hooks for external VBUS > + * power switch and overcurrent detect > + */ > + if ((gpio_request(gpio + 1, "GPIO_EHCI_NOC") < 0) || > + (gpio_direction_input(gpio + 1) < 0)) > + pr_err("IGEP2: Could not obtain gpio for EHCI NOC"); Shouldb't you return error if it can't request the GPIO? > + > + /* > + * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN > + * (out, active low) > + */ > + if ((gpio_request(gpio + TWL4030_GPIO_MAX, "GPIO_USBH_CPEN") < 0) || > + (gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0) < 0)) > + pr_err("IGEP2: Could not obtain gpio for USBH_CPEN"); Same here. > + > return 0; > }; > > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html