GERBER Patrick <Patrick.Gerber@xxxxxxxxxx> writes: > Hello all, > > I have compiled a fresh clone of the linux-omap-2.6 kernel for overo and I have linker error. > > The serial.c and pm34xx.c files used some variables declared as > extern. The real declaration of those variables are on pm-debug.c and > are compiled only with CONFIG_PM_DEBUG. Hi Patric, thanks for the patch. A couple days ago, a similar patch was posted by Loïc Minier to fix the same issue, and I'm waiting an updated version of his patch. > So I have added some #ifdef to correct the error. I don't know if it's > the best idea but anyway with the attached patch it's work. Adding #ifdefs in this way is generally not done in the kernel. For another example of how to solve the same problem, see the patch from Loïc. Also see the '#ifdefs are ugly' section of Documentation/SubmittingPatches in the kernel source. Thanks again for contributing your fixes back, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
