>>-----Original Message----- >>From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] >>Sent: Thursday, September 30, 2010 4:50 AM >>To: Gopinath, Thara >>Cc: linux-omap@xxxxxxxxxxxxxxx; paul@xxxxxxxxx; Cousson, Benoit; Sripathy, >>Vishwanath; Sawant, Anand >>Subject: Re: [PATCH v3 08/11] OMAP3: PM: Adding debug support to Voltage and >>Smartreflex drivers >> >>Thara Gopinath <thara@xxxxxx> writes: >> >>[...] >> >>> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat- >>omap/include/plat/voltage.h >>> index 99836a1..8978d33 100644 >>> --- a/arch/arm/plat-omap/include/plat/voltage.h >>> +++ b/arch/arm/plat-omap/include/plat/voltage.h >>> @@ -14,6 +14,11 @@ >>> #ifndef __ARCH_ARM_MACH_OMAP2_VOLTAGE_H >>> #define __ARCH_ARM_MACH_OMAP2_VOLTAGE_H >>> >>> +extern u32 enable_sr_vp_debug; >>> +#ifdef CONFIG_PM_DEBUG >>> +extern struct dentry *pm_dbg_main_dir; >>> +#endif >>> + >>> #define VOLTSCALE_VPFORCEUPDATE 1 >>> #define VOLTSCALE_VCBYPASS 2 >> >>This belongs in PATCH 1/11 and belongs in pm.h, not voltage.h as it's a >>feature of the PM debug layer, not the voltage layer. Yes indeed!! Will fix this in v4 Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html