Hi Paul, > -----Original Message----- > From: Paul Walmsley [mailto:paul@xxxxxxxxx] > Sent: Thursday, September 30, 2010 3:06 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Tony Lindgren; Menon, Nishanth > Subject: Re: [PATCH v2 03/10] OMAP: mach-omap2: Fix static > function warnings > > Hello Manjunath, > > one comment: > > On Tue, 21 Sep 2010, G, Manjunath Kondaiah wrote: > > > arch/arm/mach-omap2/powerdomain.c | 28 > ------------------------ > > 12 files changed, 27 insertions(+), 47 deletions(-) create mode > > 100644 arch/arm/mach-omap2/include/mach/board-rx51.h > > > > diff --git a/arch/arm/mach-omap2/powerdomain.c > > b/arch/arm/mach-omap2/powerdomain.c > > index 6527ec3..6e51079 100644 > > --- a/arch/arm/mach-omap2/powerdomain.c > > +++ b/arch/arm/mach-omap2/powerdomain.c > > @@ -981,34 +981,6 @@ bool pwrdm_has_hdwr_sar(struct powerdomain > > *pwrdm) } > > > > /** > > - * pwrdm_set_lowpwrstchange - Request a low power state change > > - * @pwrdm: struct powerdomain * > > - * > > - * Allows a powerdomain to transtion to a lower power sleep state > > - * from an existing sleep state without waking up the powerdomain. > > - * Returns -EINVAL if the powerdomain pointer is null or if the > > - * powerdomain does not support LOWPOWERSTATECHANGE, or returns 0 > > - * upon success. > > - */ > > -int pwrdm_set_lowpwrstchange(struct powerdomain *pwrdm) -{ > > - if (!pwrdm) > > - return -EINVAL; > > - > > - if (!(pwrdm->flags & PWRDM_HAS_LOWPOWERSTATECHANGE)) > > - return -EINVAL; > > - > > - pr_debug("powerdomain: %s: setting LOWPOWERSTATECHANGE bit\n", > > - pwrdm->name); > > - > > - prm_rmw_mod_reg_bits(OMAP4430_LOWPOWERSTATECHANGE_MASK, > > - (1 << OMAP4430_LOWPOWERSTATECHANGE_SHIFT), > > - pwrdm->prcm_offs, pwrstctrl_reg_offs); > > - > > - return 0; > > -} > > - > > Please don't delete this function. It will be needed for > OMAP4 power management. Instead, just add a prototype in > plat-omap/include/plat/powerdomains.h. Thanks. Taken care with new pull request sent to tony. -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
