Tony, > -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Saturday, September 25, 2010 5:49 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [GIT PULL] omap2 sparse fixes > > * G, Manjunath Kondaiah <manjugk@xxxxxx> [100924 12:33]: > > > > Tony, > > Here is new pull request which is rebased to 2.6.36-rc5. > > > > -Manjunath > > > > The following changes since commit > b30a3f6257ed2105259b404d419b4964e363928c: > > Linus Torvalds (1): > > Linux 2.6.36-rc5 > > > > are available in the git repository at: > > > > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git > > sparse_fixes > > > > G, Manjunath Kondaiah (10): > > OMAP: mach-omap2: Fix incorrect assignment warnings > > OMAP: mach-omap2: Fix static declaration warnings > > OMAP: mach-omap2: Fix static function warnings > > OMAP: mach-omap2: Fix miscellaneous sparse warnings > > OMAP: plat-omap: Fix static function warnings > > OMAP: NAND: Fix static declaration warning > > TWL CORE: Fix sparse warning > > TWL IRQ: Fix fucntion declaration warnings > > OMAP2/3: Convert write/read functions to raw read/write > > OMAP3: Keypad: Fix incorrect type initializer > > Hmm tried pulling these, but ran into an issue where at least > 2430 takes about a minute to boot with these patches with no > output on the console intially. > > Can you please check that? Will not merge for now until we > figure out what changes with these patches. > > Then, I also noticed the following exports getting added: > > +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer); > +EXPORT_SYMBOL(omapfb_reserve_sram); > +EXPORT_SYMBOL(omap_sram_init); > > These should not be exported, they are only intended to be > called from the low-level platform init code. So exporting > them is not the right fix for these. Similar comments received for twl irq apis's hence it was aligned to declare these functions as extern functions in local header(if exists) or create new header in the source file directory for these declarations. Three patches are fixed using above method which are: OMAP: mach-omap2: Fix static function warnings OMAP: plat-omap: Fix static function warnings TWL IRQ: Fix fucntion declaration warnings The patch series is tested on below boards(with omap3_defconfig) and links for boot logs is provided below: beagle boot log: http://pastebin.com/jz6ZGHsH zoom3 boot log: http://pastebin.com/T0YjunCk 2430sdp boot log: http://pastebin.com/7BbpieYS As I mentioned in other e-mail, 2430sdp with omap3_defconfig boots only after disabling usb. OMAP4SDPES2.0 boots with ES2.0 patches from for-next branch. Here is all parse errors fixed with this series: Sparse warns before fixes: http://pastebin.com/yct2p201 Sparse warns after fixes: http://pastebin.com/qpnTbYwL All the tested patches are pushed to new branch at: The following changes since commit b30a3f6257ed2105259b404d419b4964e363928c: Linus Torvalds (1): Linux 2.6.36-rc5 are available in the git repository at: git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes_v3 G, Manjunath Kondaiah (10): OMAP: mach-omap2: Fix incorrect assignment warnings OMAP: mach-omap2: Fix static declaration warnings OMAP2plus: Fix static function warnings OMAP: mach-omap2: Fix miscellaneous sparse warnings OMAP: plat-omap: Fix static function warnings OMAP: NAND: Fix static declaration warning TWL CORE: Fix sparse warning TWL IRQ: Fix fucntion declaration warnings OMAP2/3: Convert write/read functions to raw read/write OMAP3: Keypad: Fix incorrect type initializer -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
