Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 27, 2010 at 04:48:04AM -0500, Sergei Shtylyov wrote:
Hello.

On 27-09-2010 10:07, Felipe Balbi wrote:

I guess that's Felipe's call, but I don't like that option.

I think it's cleaner to have the ->set_clock hook be a noop on OMAP and
the runtime hooks be noops on the other platforms.

Agreed. We should focus on removing ->set_clock for .38 actually. Is
DaVinci already using clkdev, Kevin ?

Sure. But DaVinci doesn't use ->set_clock().

Ok, so seems like no-one is actually using that.

   I thought OMAP does... but I'm seeing now that it doesn't.

We can already start
patching to remove that thing, later on, we need to remove the clock
name via platform_data.

   As I've said already, there are cases where two clocks is needed by MUSB
(like AM3517) or where USB 2.0 clock is also needed by the OHCI driver
(DA8xx), hence the name seems needed still...

we can all go through all that discussion with Russell again and will
come down to the same conclusion: clock names should never be needed.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux