Re: [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Loïc,

Loïc Minier <loic.minier@xxxxxxxxxx> writes:

> Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
> enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
> isn't set:
> arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
> arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
> arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
> arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
>
> Simply #define these in pm.h just like omap2_pm_debug.

Could you move these down into the exisint #ifdef CONFIG_PM_DEBUG a
little bit later in the file (after where omap2_pm_debug.)

Also, could you sign-off on the patch please?

Thanks,

Kevin

> ---
>  arch/arm/mach-omap2/pm.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 77770a1..68db3a7 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -13,8 +13,13 @@
>  
>  #include <plat/powerdomain.h>
>  
> +#ifdef CONFIG_PM_DEBUG
>  extern u32 enable_off_mode;
>  extern u32 sleep_while_idle;
> +#else
> +#define enable_off_mode 0
> +#define sleep_while_idle 0
> +#endif
>  
>  extern void *omap3_secure_ram_storage;
>  extern void omap3_pm_off_mode_enable(int);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux