Hi Manjunath, On Mon, Sep 27, 2010 at 07:19:33PM +0530, G, Manjunath Kondaiah wrote: > > > No, we don't want to export those. Try defining them as extern from > > > twl*-irq.c. > > > > Having extern in .c file will generate checkpatch warning as: > > WARNING: externs should be avoided in .c files > > As an alternate, how about having twl-core.h in drivers/mfd and defining them > as extern so that these API's will be available only to files under drivers/mfd? > That would be better, yes. Even though exporting those definititions through linux/i2c/twl.h is harmless. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
