Re: [PATCH v3] omap: beagle: add support for wl1271 on the board file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 25, 2010 at 12:41 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Luciano Coelho <luciano.coelho@xxxxxxxxx> [100924 11:42]:
>> On Fri, 2010-09-24 at 20:03 +0200, ext John W. Linville wrote:
>> > On Thu, Sep 23, 2010 at 01:03:35PM +0300, Luciano Coelho wrote:
>> > > Add board configuration for the wl1271 daughter board.  This patch is based
>> > > on Ohad Ben-Cohen's patches for Zoom boards.
>> > >
>> > > Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
>> > > Signed-off-by: Luciano Coelho <luciano.coelho@xxxxxxxxx>
>> > > ---
>> > > from v2 to v3: removed accidental change to wl1271.h
>> >
>> > I presume that this should come through my tree as well (since it
>> > contains the move of wl12xx.h)?
>>
>> Yes, this is based on your tree.  But please hold on, because there were
>> some comments (namely, the expansion board should be detected, not
>> configured for wl1271 by default), which I still have to fix.  I'm
>> waiting for the manufacturer of the expansion board to provide me with
>> some more info for proper detection.
>>
>> Also, I know that there are some other work being done in the beagle
>> board file, so we may need to rethink how to sync this.
>>
>> So, for now, let's skip this patch and I'll provide another one when
>> these issues are addressed.
>
> You could also do it based on some kernel cmdline option. Of course
> detection during the runtime would be better.
>

This seems to be a generic problem that many boards with potential for
adding expansion boards seem to have. How about one of these options:
(a) having u-boot modify ATAGS_REVISION based on an environment variable
or
(b) add a generic board_revision kernel command line parameter that
each such board file can parse

By default - with no special command line options -  peripherals for
the most common board revision could be picked. Anyway a user that
uses such a daughterboard would know to modify the kernel command
line, or set an environment variable in u-boot, (or use a custom
u-boot) so this could scale well.

What do you think?

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux