Re: [PATCH 5/9 v3] usb: musb: Using omap_device_build for musb device registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On Thu, 23 Sep 2010, Felipe Balbi wrote:

> Paul, Kevin, to me it looks like a duplication that all devices will
> have to:
> 
> oh = omap_hwmod_lookup("my_hwmod_name");
> omap_device_build("my_device_name", bus_id, oh, pdata, sizeof(*pdata));
> 
> could the omap_hwmod_lookup() part be moved to omap_device_build ? Or
> maybe create a omap_hwmod_lookup_and_build(oh_name, dev_name, bus_id,
> pdata, sizeof(*pdata)) ??

... (re dma mask) ...

> I think this is also a duplication, it's gonna on all hwmod device
> registration, no ?

Probably at some point in the future, once a larger set of hwmod 
conversions are done, we can look at the way that most of the integration 
code initializes.  Ideally, we can combine as much common code together as 
possible into some data-driven approach.  But right now I think it's a 
little early to do that, since I personally am not sure what most 
drivers/devices will need to do in their integration code.  On the other 
hand, it's not too early to start thinking about it :-)


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux