Re: [PATCH v2] omap: beagle: add support for wl1271 on the board file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 23, 2010 at 5:30 AM, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote:
> On Thu, Sep 23, 2010 at 11:20 AM, Luciano Coelho
> <luciano.coelho@xxxxxxxxx> wrote:
>> Add board configuration for the wl1271 daughter board.  This patch is based
>> on Ohad Ben-Cohen's patches for Zoom boards.
>
> Hm can that daughter board be detected? With your patch all beagle
> users will get GPIO139 toggled, and if someone has that wired to
> chainsaw switch somebody might get hurt.

Expansion boards really need to follow:

http://elinux.org/BeagleBoardPinMux#Expansion_boards

Is there any eeprom on i2c bus #2 for identification on this board?

Otherwise this is going to break a bunch of existing adapters.

Regards,

>
>> Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
>> Signed-off-by: Luciano Coelho <luciano.coelho@xxxxxxxxx>
>> ---
>> There was a useless variable defined in omap3_beagle_init() that was causing a
>> warning.  I have removed it in v2.
>>
>>  arch/arm/mach-omap2/board-omap3beagle.c |   69 +++++++++++++++++++++++++++++++
>>  drivers/net/wireless/wl12xx/wl1271.h    |    2 +-
>>  2 files changed, 70 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
>> index 87969c7..755df29 100644
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>
> <snip>
>
>> +static struct regulator_consumer_supply beagle_vmmc2_supply = {
>> +       .supply         = "vmmc",
>> +       .dev_name       = "mmci-omap-hs.1",
>> +};
>> +
>> +
>
> single newline is enough.
>
>>  static struct regulator_consumer_supply beagle_vsim_supply = {
>>        .supply                 = "vmmc_aux",
>>  };
>>
>> +
>
> here too.
>
>> +static struct regulator_init_data beagle_vmmc2 = {
>> +       .constraints = {
>> +               .valid_ops_mask = REGULATOR_CHANGE_STATUS,
>> +       },
>> +       .num_consumer_supplies = 1,
>> +       .consumer_supplies = &beagle_vmmc2_supply,
>> +};
>> +
>> +static struct fixed_voltage_config beagle_vwlan = {
>> +       .supply_name = "vwl1271",
>> +       .microvolts = 1800000,  /* 1.8V */
>> +       .gpio = OMAP_BEAGLE_WLAN_EN_GPIO,
>> +       .startup_delay = 70000, /* 70ms */
>> +       .enable_high = 1,
>> +       .enabled_at_boot = 0,
>> +       .init_data = &beagle_vmmc2,
>> +};
>
> We tabify all structures in board files, take a look at other structures.
>
> <snip>
>
>> diff --git a/drivers/net/wireless/wl12xx/wl1271.h b/drivers/net/wireless/wl12xx/wl1271.h
>> index 4134f44..8bb028e 100644
>> --- a/drivers/net/wireless/wl12xx/wl1271.h
>> +++ b/drivers/net/wireless/wl12xx/wl1271.h
>> @@ -60,7 +60,7 @@ enum {
>>        DEBUG_ALL       = ~0,
>>  };
>>
>> -#define DEBUG_LEVEL (DEBUG_NONE)
>> +#define DEBUG_LEVEL (DEBUG_MAC80211 | DEBUG_CMD | DEBUG_ACX | DEBUG_BOOT)
>
> I guess you didn't want that?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Robert Nelson
http://www.rcn-ee.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux