> > > > Why not these defines in mach-omap2/dmtimer.c? since register offsets > are > > same for omap2plus except omap4 which has additional register offsets. > Same > > register offsets are getting repeated in all the omap2plus hwmod > database. > > I agree with Manjunath. > > > As kevin suggested for DMA hwmod, i2c driver is already using these > defines > > in .c file even though register offsets are different within omap2plus > processors. > > through dev structure. > > > > Can we have similar kind of usage for all upcoming driver hwmod > adaptations? > > Yes please. > > hwmod is not the place for register definitions, specially when OMAP4 is > the only difference. I can move it to its original place in mach-omap2. The reason for re-location was if OMAP 5 and later version had different mappings we had to keep on adding new table in mach-omap2 in addition to applying sort if() checks for the different platforms. -tarun -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
