> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Tuesday, September 21, 2010 9:47 AM > To: Madhusudhan > Cc: cjb@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; > santosh.shilimkar@xxxxxx > Subject: Re: [PATCH] OMAP4: HSMMC cmd line reset change > > * Madhusudhan <madhu.cr@xxxxxx> [100920 09:06]: > > > > > > Please don't use cpu_is_omapxxxx tests in the drivers, drivers > > > should be generic. > > > > > > Instead, just pass a feature flag in the platform_data for this > > > feature like HSMMC_REVERSE_RESET_LOGIC or similar. > > > > > > > This is not a feature. It is like an ERRATA fix. I am yet to receive an > > errata number though. How about dealing with this like an errata fix > similar > > to the way in arch/mach-omap2/serial.c done for the uart case? > > Yes setting some HSMMC_ERRATA_XYZ flag works too. > > > The mmc ip revision will not help because it really does not change to > > distinguish such issues. > > OK. Then I guess your only option is to pass the errata flag in > the platform_data. > Chris, Can you please drop this patch? Sorry, I spoke bit too early on this patch. I need to sort out some stuff internally (seems like it will not be released as an errata). I will post a revised version a bit later. Regards, Madhu > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
