On Fri, Sep 17, 2010 at 09:43:16AM +0300, Felipe Balbi wrote: > On Thu, Sep 16, 2010 at 06:39:20AM -0500, Munegowda, Keshava wrote: > >>-----Original Message----- > >>From: Munegowda, Keshava > >>Sent: Tuesday, September 14, 2010 4:40 AM > >>To: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > >>Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava > >>Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit > >> > >>The un-registration of OHCI driver was not done in > >>the ohci_hcd_mod_exit function. This was affecting rmmod command not > >>to work for OMAP3 platforms. > >>The platform driver un-registration for OMAP3 platforms is perfomed > >>while removing the OHCI module from kernel. > >> > >>Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx> > >>--- > >> drivers/usb/host/ohci-hcd.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >>Index: linux-2.6/drivers/usb/host/ohci-hcd.c > >>=================================================================== > >>--- linux-2.6.orig/drivers/usb/host/ohci-hcd.c > >>+++ linux-2.6/drivers/usb/host/ohci-hcd.c > >>@@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi > >> #ifdef PLATFORM_DRIVER > >> platform_driver_unregister(&PLATFORM_DRIVER); > >> #endif > >>+#ifdef OMAP3_PLATFORM_DRIVER > >>+ platform_driver_unregister(&OMAP3_PLATFORM_DRIVER); > >>+#endif > >> #ifdef PS3_SYSTEM_BUS_DRIVER > >> ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER); > >> #endif > > > >Hi Greg, > > Do you any comments on this patch? > > my missing S-O-B, maybe. Here it goes: > > Signed-of-by: Felipe Balbi <balbi@xxxxxx> Yup, all good now. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
