RE: [PATCH] usb: omap: ohci: Missing driver unregister in module exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Munegowda, Keshava
> Sent: Tuesday, September 14, 2010 4:40 AM
> To: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx
> Cc: Gadiyar, Anand; Kamat, Nishant; Munegowda, Keshava
> Subject: [PATCH] usb: omap: ohci: Missing driver unregister in module exit
> 
> The un-registration of OHCI driver was not done in
> the ohci_hcd_mod_exit function. This was affecting rmmod command not
> to work for OMAP3 platforms.
> The platform driver un-registration for OMAP3 platforms is perfomed
> while removing the OHCI module from kernel.
> 
> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx>
> ---
>  drivers/usb/host/ohci-hcd.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6/drivers/usb/host/ohci-hcd.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/host/ohci-hcd.c
> +++ linux-2.6/drivers/usb/host/ohci-hcd.c
> @@ -1270,6 +1270,9 @@ static void __exit ohci_hcd_mod_exit(voi
>  #ifdef PLATFORM_DRIVER
>  	platform_driver_unregister(&PLATFORM_DRIVER);
>  #endif
> +#ifdef OMAP3_PLATFORM_DRIVER
> +	platform_driver_unregister(&OMAP3_PLATFORM_DRIVER);
> +#endif
>  #ifdef PS3_SYSTEM_BUS_DRIVER
>  	ps3_ohci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER);
>  #endif

Hi Greg,
     Do you any comments on this patch? 

Keshava Munegowda

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux