2010/9/15 Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>: > OMAP SOCs have a standard set of tuples consisting of frequency and > voltage pairs that the device will support per voltage domain. These > are called Operating Performance Points or OPPs. > (...) > This introduces a common handling OPP mechanism accross all OMAPs. > As a start this is used for OMAP3. OPPs are a generic concept, it's in silicon construction textbooks and all. Should this code not be made generic instead? You wouldn't make regulators or even DMA platform-specific these days, so why should OPPs be? What in this code is actually OMAP-specific, more than that you name some functions omap_*, and how hard would it be to put it under arch/arm/common/*.c arch/arm/include/asm/*.h Possible even higher up in the directory hiearchy in include/linux/opp.h for the header and drivers/opp/*.c, because I think SuperH and power are not that different in this respect. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
