>>-----Original Message----- >>From: Menon, Nishanth >>Sent: Thursday, September 16, 2010 4:02 PM >>To: Gopinath, Thara; Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx >>Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >>Subject: RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs >> >>> -----Original Message----- >>> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- >>> owner@xxxxxxxxxxxxxxx] On Behalf Of Gopinath, Thara >> >>[...] >>> >>diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat- >>> omap/include/plat/opp.h >>> >>new file mode 100644 >>> >>index 0000000..997b56e >>> >>--- /dev/null >>> >>+++ b/arch/arm/plat-omap/include/plat/opp.h >>[..] >>> >>+ >>> >>+#ifdef CONFIG_PM >>> >>+ >>[..] >>> >>+struct omap_opp *opp_find_freq_ceil(struct device *dev, unsigned long >>> *freq); >>> >>+ >>> >>+int opp_add(const struct omap_opp_def *opp_def); >>> >>+ >>> >>+int opp_enable(struct omap_opp *opp); >>> >>+ >>> >>+int opp_disable(struct omap_opp *opp); >>> >>+ >>> >>+void opp_init_cpufreq_table(struct device *dev, >>> >>+ struct cpufreq_frequency_table **table); >>> >>+#else >>> >>> Hello Kevin, >>> >>> IN case of CONFIG_PM not being defined the else part will cause a >>> compilation break as >>> the signature of these APIs defined in the else part do not match with the >>> signature in >>> the if part. >>> >>Thanks for the catch. Will send a patch for this. I learnt this the hard way by actually hitting the issue :-)!! Regards Thara -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
