> -----Original Message----- > From: Balbi, Felipe > Sent: Tuesday, September 14, 2010 3:54 PM > To: G, Manjunath Kondaiah > Cc: Kevin Hilman; linux-omap@xxxxxxxxxxxxxxx; Cousson, > Benoit; Shilimkar, Santosh > Subject: Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device > registration > > Hi, > > On Tue, Sep 14, 2010 at 05:18:52AM -0500, G, Manjunath Kondaiah wrote: > >How static inline functions are better than this? > > static inline function will at least give you type checking ?? If so, even inline function has certain disadvantages such as, A. somtimes the compiler may not be able to inline as many functions as the programmer indicates. B. Inline functions might increcase compilation time The issue in DMA driver is, if I replace dma_read/dma_write macros with inline functions, I need to remove OMAP_DMA4_##reg macro in dma_read and dma write functions and I have to expand the register names all over the place in DMA driver(like instead of CAPS0, it should be OMAP_DMA4_CAPS0, having only CAPS0 will be easier to read). -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
