> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Saturday, September 04, 2010 2:30 AM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; Cousson, Benoit; Shilimkar, Santosh > Subject: Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device > registration > > Manjunatha GK <manjugk@xxxxxx> writes: > > > This patch converts omap2/3/4 dma driver into platform > > devices through using omap hwmod, omap device and runtime pm > > frameworks. [..] > > + > > +#define dma_read(reg) > \ > > +({ > \ > > + u32 __val; > \ > > + __val = __raw_readl(dma_base + OMAP_DMA4_##reg); > \ > > + __val; > \ > > +}) > > + > > +#define dma_write(val, reg) > \ > > +({ > \ > > + __raw_writel((val), dma_base + OMAP_DMA4_##reg); > \ > > +}) > > I know these are copy paste from the original code, but please convert > into static inline functions. Ok. > > Also, I don't see dma_write() used in this patch. This is initial patch for splitting mach-omap1 and mach-omap2 contents. dma_write is used in later patches. Please refer to Patch #11 -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
